[Webkit-unassigned] [Bug 45383] [Gtk] Incorrect exposure of list items whose children are elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45383


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67918|0                           |1
        is obsolete|                            |
  Attachment #68206|                            |review?
               Flag|                            |




--- Comment #6 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-21 03:25:46 PST ---
Created an attachment (id=68206)
 --> (https://bugs.webkit.org/attachment.cgi?id=68206)
Patch proposal

(In reply to comment #5)
> (From update of attachment 67918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67918&action=review
> 
> > WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:76
> > +    // Include all list items, regardless they have or not inline children
> 
> seems like you already have "role" here, so you shouldn't have to call roleValue() again

Done and also fixed the same mistake in the next line (introduced some commits ago).

> > WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2031
> > +            if (role != TableRole && axRenderObject->renderer()->childrenInline())
> 
> you should verify renderer() is not nil before accessing inline children

Done.

> > WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2036
> > +                AccessibilityObject* axRenderChild = axRenderObject->firstChild();
> 
> Can't you just access ->children() of the axRenderObject and then check if it has an item in it? that would be the first accessible element.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.