[Webkit-unassigned] [Bug 45383] [Gtk] Incorrect exposure of list items whose children are elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45383


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67918|review?                     |review-
               Flag|                            |




--- Comment #5 from chris fleizach <cfleizach at apple.com>  2010-09-20 11:19:10 PST ---
(From update of attachment 67918)
View in context: https://bugs.webkit.org/attachment.cgi?id=67918&action=review

> WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:76
> +    // Include all list items, regardless they have or not inline children

seems like you already have "role" here, so you shouldn't have to call roleValue() again

> WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2031
> +            if (role != TableRole && axRenderObject->renderer()->childrenInline())

you should verify renderer() is not nil before accessing inline children

> WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2036
> +                AccessibilityObject* axRenderChild = axRenderObject->firstChild();

Can't you just access ->children() of the axRenderObject and then check if it has an item in it? that would be the first accessible element.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.