[Webkit-unassigned] [Bug 46086] Web Inspector: implement pausing on XHR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46086





--- Comment #4 from Yury Semikhatsky <yurys at chromium.org>  2010-09-21 00:10:25 PST ---
(From update of attachment 68079)
View in context: https://bugs.webkit.org/attachment.cgi?id=68079&action=review

>> WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:117
>> +    InspectorController::willSendXHR(xmlHttpRequest->scriptExecutionContext(), xmlHttpRequest->url());
> 
> I'd suggest calling it:
> 
> InspectorController::instrumentWillSendXmlHttpRequest
> 
> And all others will be 'instrument*'.

It should be easy to support same functionality in JSC. There is already a bug about missing ScriptDebuggServer::breakProgram implementation in JSC which prevents this change from working in JSC but this functionality might deserve filing its own bug.

> WebCore/inspector/InspectorDebuggerAgent.h:99
> +    bool pauseOnEventState(unsigned eventType);

pauseOnEventState -> shouldPauseOnEvent

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.