[Webkit-unassigned] [Bug 46086] Web Inspector: implement pausing on XHR
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 20 07:43:30 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=46086
Pavel Feldman <pfeldman at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #68079|review? |review+
Flag| |
--- Comment #3 from Pavel Feldman <pfeldman at chromium.org> 2010-09-20 07:43:30 PST ---
(From update of attachment 68079)
r+ with nits. I'd actually suggest adding one more item into the native breakpoints list: "Any JavaScript statement" that is On by default. In addition to that, you change behavior of the Pause button respectively.
View in context: https://bugs.webkit.org/attachment.cgi?id=68079&action=review
> WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:34
> +#include "InspectorController.h"
Please mind import order.
> WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:117
> + InspectorController::willSendXHR(xmlHttpRequest->scriptExecutionContext(), xmlHttpRequest->url());
I'd suggest calling it:
InspectorController::instrumentWillSendXmlHttpRequest
And all others will be 'instrument*'.
> WebCore/inspector/Inspector.idl:127
> + [handler=Debug] void setPauseOnEventState(in unsigned int eventType, in boolean state);
pauseOnNextEvent ?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list