[Webkit-unassigned] [Bug 45891] DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45891





--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-09-20 09:33:29 PST ---
(In reply to comment #5)
> > Someone should review this from the mac port side.
> Added Chris and Simon who looked at the original patch to add the Mac client.
> 
> > Darin, any thoughts about the naming of the methods?
> The naming for existing clients doesn't seem to follow a precise pattern. Usually, with a FooController and a FooClient, the method is fooControllerDestroyed(), but there are exceptions, such as {Chrome, ChromeClient, chromeDestroyed()} and {GeolocationController, GeolocationControllerClient and geolocationDestroyed()}.
> 
> deviceOrientationControllerDestroyed() seemed needlessly wordy, as it's pretty obvious which controller has been destroyed, so I went with controllerDestroyed().

You could run into a problem if you ever want to have a class that implements multiple Client interfaces.  Suppose two Client interfaces both declare controllerDestroyed() methods.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.