[Webkit-unassigned] [Bug 45891] DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods

Mon Sep 20 02:34:18 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45891

Steve Block <steveblock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cmarrin at apple.com,
                   |                            |simon.fraser at apple.com

--- Comment #5 from Steve Block <steveblock at google.com>  2010-09-20 02:34:18 PST ---
> Someone should review this from the mac port side.
Added Chris and Simon who looked at the original patch to add the Mac client.

> Darin, any thoughts about the naming of the methods?
The naming for existing clients doesn't seem to follow a precise pattern. Usually, with a FooController and a FooClient, the method is fooControllerDestroyed(), but there are exceptions, such as {Chrome, ChromeClient, chromeDestroyed()} and {GeolocationController, GeolocationControllerClient and geolocationDestroyed()}.

deviceOrientationControllerDestroyed() seemed needlessly wordy, as it's pretty obvious which controller has been destroyed, so I went with controllerDestroyed().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.