[Webkit-unassigned] [Bug 45145] [Qt] V8 port for QT platform: v8 binding changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45145





--- Comment #18 from Simon Hausmann <hausmann at webkit.org>  2010-09-20 02:48:10 PST ---
(In reply to comment #17)
> > > WebCore/bindings/v8/V8Binding.cpp:54
> > > -        : m_plainString(string)
> > > +        : m_plainString(reinterpret_cast<const WTF::String &>(string))
> > I don't understand this code.  Does Qt use different string types than other ports?  reinterpret_cast is almost always wrong.
> 
> As I said earlier without explicit cast compiler gives an error b/c of confusion b/n
> "WTF::String::String(const QString &) or
> "WTF::String::String(const WTF::String &)

We have solved this one differently now:

http://trac.webkit.org/changeset/67326

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.