[Webkit-unassigned] [Bug 45145] [Qt] V8 port for QT platform: v8 binding changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45145





--- Comment #17 from Vlad <vladbph at gmail.com>  2010-09-17 12:43:51 PST ---
(In reply to comment #13)
> (From update of attachment 66574 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66574&action=prettypatch
> 
> > WebCore/bindings/v8/ScriptController.cpp:74
> > +#if PLATFORM(QT)
> > +PassRefPtr<DOMWrapperWorld> ScriptController::createWorld()
> > +{
> > +    return DOMWrapperWorld::create();
> > +}
> > +#endif
> This can't be right.  It's not Qt-specific.  We need to integrate V8 with DOMWrapperWorld in genera.
It is not Qt specific code and ifdef should be removed. I was trying to isolate Qt+v8 related changes.

> 
> > WebCore/bindings/v8/V8Binding.cpp:54
> > -        : m_plainString(string)
> > +        : m_plainString(reinterpret_cast<const WTF::String &>(string))
> I don't understand this code.  Does Qt use different string types than other ports?  reinterpret_cast is almost always wrong.

As I said earlier without explicit cast compiler gives an error b/c of confusion b/n
"WTF::String::String(const QString &) or
"WTF::String::String(const WTF::String &)

> 
> > WebCore/plugins/win/PluginViewWin.cpp:661
> > +#if USE(JSC)
> >      JSC::JSLock::DropAllLocks dropAllLocks(JSC::SilenceAssertionsOnly);
> > +#endif
> This ifdefs point to a missing abstraction.  Perhaps a ScriptLock object?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.