[Webkit-unassigned] [Bug 45416] Allow Chromium port to link with system-provided SQLite

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45416





--- Comment #6 from Dumitru Daniliuc <dumi at chromium.org>  2010-09-16 21:24:19 PST ---
> > platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:47
> >  namespace {
> Converted to statics. Please note the anonymous namespace was there before.

yeah, i know, was one of my first webkit patches...

> > platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:768
> > +    if (fsync(pFile->h)) {
> That was the simplest implementation. We can do something more fancy on Mac, but it's more risky (I was developing this on Linux). I can add a TODO(phajdan.jr) to port the Mac logic here when I switch to the Mac checkout.

we _have_ to do exactly what sqlite's vfs does (on linux _and_ on mac). otherwise, we'll end up with subtle bugs that will take months to debug.

> > platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:1090
> >      sqlite3_vfs* unix_vfs = sqlite3_vfs_find("unix");
> We still need it for other things, like xDlError, xSleep, xCurrentTime, and so on.

we should copy-paste + modify those too, and remove any references to the "unix" VFS: either we reuse as much of it as possible, or we don't use it at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.