[Webkit-unassigned] [Bug 45416] Allow Chromium port to link with system-provided SQLite

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 11:56:43 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=45416





--- Comment #5 from Paweł Hajdan, Jr. <phajdan.jr at chromium.org>  2010-09-16 11:56:43 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=66952&action=prettypatch

Thanks for the review. The updated patch is already uploaded (from a WebKit checkout), and ready for another review. Please take a look.

> platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:47
>  namespace {
Converted to statics. Please note the anonymous namespace was there before.

> platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:205
> +    struct stat statbuf;
We need it for struct stat. Removal results in a compile error.

> platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:330
> +    struct flock lock;
This one could be removed. Done.

> platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:334
> +    lock.l_len = SQLiteSharedSize;
We don't use SQLite whole file locking, so I have removed it from this patch.

> platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:768
> +    if (fsync(pFile->h)) {
That was the simplest implementation. We can do something more fancy on Mac, but it's more risky (I was developing this on Linux). I can add a TODO(phajdan.jr) to port the Mac logic here when I switch to the Mac checkout.

> platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:940
> +    struct stat sStat;
Removal results in a compile error.

> platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:1090
>      sqlite3_vfs* unix_vfs = sqlite3_vfs_find("unix");
We still need it for other things, like xDlError, xSleep, xCurrentTime, and so on.

> platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:1094
>          unix_vfs->mxPathname,
While we have unix_vfs here, I thought it would be useful to reuse it. Do you still think it's worth to duplicate this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list