[Webkit-unassigned] [Bug 44709] deduplicate-tests should be runnable from any WebKit directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44709


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67259|review?                     |review+
               Flag|                            |




--- Comment #22 from Eric Seidel <eric at webkit.org>  2010-09-15 17:17:32 PST ---
(From update of attachment 67259)
View in context: https://bugs.webkit.org/attachment.cgi?id=67259&action=prettypatch

Looks fine, but I think you want to cache find_checkout_root()

> WebKitTools/Scripts/webkitpy/layout_tests/deduplicate_tests.py:111
> +            cwd=scm.find_checkout_root())
find_checkout_root is kinda expensive (hits the disk).  Maybe your object shoudl cache it somewhere?  If this was an actual Command object with a tool.scm, you would just grab tool.scm.checkout_root. :(   Bug 45838 is kinda blocking nice non-webkit-patch webkitpy development in this way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.