[Webkit-unassigned] [Bug 44709] deduplicate-tests should be runnable from any WebKit directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44709





--- Comment #21 from Tony Chang <tony at chromium.org>  2010-09-10 16:25:56 PST ---
(In reply to comment #17)
> (From update of attachment 67251 [details])
> This very long docstring ends up basically saying the same thing 3 times.  Especially with the comment about ospath.relpath below it too. :(

Shorted and removed the redundant comment.

> > WebKitTools/Scripts/webkitpy/layout_tests/deduplicate_tests.py:180
> > +    path = ospath.relpath(os.path.normpath(abs_path),
> > +                          os.path.normpath(relative_to))
> > +    return path
> Just return the result directly, no?

Done.

> > WebKitTools/Scripts/webkitpy/layout_tests/deduplicate_tests.py:218
> > +                yield {'test': test, 'platform': platform,
> > +                       'fallback': fallback, 'path': path}
> I would have written this as one per line:
> 
> yield {
>   'test': foo,
>    'bar: bar,
> }

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.