[Webkit-unassigned] [Bug 41510] Add Base64DecodePolicy option at base64Decode()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41510





--- Comment #45 from Patrick R. Gansterer <paroga at paroga.com>  2010-09-14 11:11:01 PST ---
(In reply to comment #44)
> The crash is not introduced by your changes?
I don't thinks so, but I don't have a mac to evaluate it. It was already hard enough to find a (possible?) fix. But maybe someone will send me one? ;-)

> If this is a pre-existing bug, this fix should go in separately.
I don't know what it fixes exactly, because I can check. :-( IMHO it should crash if you only apply my LayoutTest changes. I added test cases for invalid stylesheets, what maybe causes the crash.

> Maybe you think “existing code” means an earlier version of your patch?
existing code = SVN trunk

> I think maybe you misunderstood my question. What was the behavior of this method if called in this way before any of your changes?
I think a crash, but can't try.

> > IMHO we should set it to an empty string, because this is the best (string) representation for invalid. If we can remove the setting that would be better (but I don't know how to do it).
> 
> Empty string sounds OK.
Can you post me a snippet for it? I'm not sure if a >>locationString = ""<< will work, because it is a NSURL*.

> > I saw such an if statement in the file and copied it.
> 
> Understood. Not the best thing to do in this case, I think.
You're right, sorry!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.