[Webkit-unassigned] [Bug 41510] Add Base64DecodePolicy option at base64Decode()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41510





--- Comment #44 from Darin Adler <darin at apple.com>  2010-09-14 10:55:00 PST ---
(In reply to comment #43)
> (In reply to comment #42)
> > Under what circumstances can locationString end up nil? What is the best behavior for the API in that case? Is this a change from the behavior of the existing code?
> I don't think that we change behaviour, because it crashes at the moment (not so cool behaviour ;-))

The crash is not introduced by your changes? If this is a pre-existing bug, this fix should go in separately. Maybe you think “existing code” means an earlier version of your patch?

I think maybe you misunderstood my question. What was the behavior of this method if called in this way before any of your changes?

> IMHO we should set it to an empty string, because this is the best (string) representation for invalid. If we can remove the setting that would be better (but I don't know how to do it).

Empty string sounds OK.

> I saw such an if statement in the file and copied it.

Understood. Not the best thing to do in this case, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.