[Webkit-unassigned] [Bug 45466] [WINCE] Replace codePage instead of TextEncoding

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 14 08:53:12 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=45466


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67052|0                           |1
        is obsolete|                            |
  Attachment #67558|                            |commit-queue?
               Flag|                            |




--- Comment #4 from Patrick R. Gansterer <paroga at paroga.com>  2010-09-14 08:53:12 PST ---
Created an attachment (id=67558)
 --> (https://bugs.webkit.org/attachment.cgi?id=67558)
Patch

(In reply to comment #3)
> > WebCore/platform/text/wince/TextCodecWinCE.cpp:136
> > -    return new TextCodecWinCE(encoding);
> > +    return new TextCodecWinCE(getCodePage(encoding.name()));
> Another option would have been to put the call to getCodePage inside the TextCodecWinCE constructor. It isn't clear to me whether that approach would be better.
IMHO there is no difference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list