[Webkit-unassigned] [Bug 45466] [WINCE] Replace codePage instead of TextEncoding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45466


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67052|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Adam Roben (aroben) <aroben at apple.com>  2010-09-14 08:42:57 PST ---
(From update of attachment 67052)
View in context: https://bugs.webkit.org/attachment.cgi?id=67052&action=prettypatch

> WebCore/ChangeLog:8
> +        Use codePage as member variable to aviod repeated lookup.
Typo: aviod

> WebCore/platform/text/wince/TextCodecWinCE.cpp:136
> -    return new TextCodecWinCE(encoding);
> +    return new TextCodecWinCE(getCodePage(encoding.name()));
Another option would have been to put the call to getCodePage inside the TextCodecWinCE constructor. It isn't clear to me whether that approach would be better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.