[Webkit-unassigned] [Bug 45165] Expose Flags constructor if FileSystem API is Enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45165





--- Comment #11 from Kinuko Yasuda <kinuko at chromium.org>  2010-09-13 14:36:38 PST ---
(In reply to comment #10)
> (From update of attachment 67159 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67159&action=prettypatch
>
> > WebCore/bindings/scripts/CodeGeneratorV8.pm:3395
> > +    if (length($signature->extendedAttributes->{"EnabledAtRuntime"}) > 1) {
> to keep this function consistent with all other helper functions, i think we should change its format to:
> 
> return "RuntimeEnabledFeatures::" . $codeGenerator->WK_lcfirst($signature->extendedAttributes->{"EnabledAtRuntime"}) . "Enabled" if ($signature->extendedAttributes->{"EnabledAtRuntime"} ne "");
> return <the default name>;

As extendedAttributes->{"EnabledAtRuntime"} has value 1 when it's set but has no values, I'm going to make the if expr look like following.   (Could you ping me if it doesn't look good.)  Thanks,

> return ... if ($signature->extendedAttributes->{"EnabledAtRuntime"}  && $signature->extendedAttributes->{"EnabledAtRuntime"} != 1);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.