[Webkit-unassigned] [Bug 45165] Expose Flags constructor if FileSystem API is Enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45165


Dumitru Daniliuc <dumi at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67159|review?                     |review+
               Flag|                            |




--- Comment #10 from Dumitru Daniliuc <dumi at chromium.org>  2010-09-13 12:45:28 PST ---
(From update of attachment 67159)
View in context: https://bugs.webkit.org/attachment.cgi?id=67159&action=prettypatch

r=me. please address the comment before landing.

> WebCore/bindings/scripts/CodeGeneratorV8.pm:3395
> +    if (length($signature->extendedAttributes->{"EnabledAtRuntime"}) > 1) {
to keep this function consistent with all other helper functions, i think we should change its format to:

return "RuntimeEnabledFeatures::" . $codeGenerator->WK_lcfirst($signature->extendedAttributes->{"EnabledAtRuntime"}) . "Enabled" if ($signature->extendedAttributes->{"EnabledAtRuntime"} ne "");
return <the default name>;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.