[Webkit-unassigned] [Bug 45446] [EFL] Add setting API to set a local storage database path.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45446





--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-09-10 23:23:51 PST ---
(In reply to comment #3)
> Hi Gyuyoung,
> 
> Yes, from an organisational point of view, you are right, we should move all setting functions to ewk_settings.{cpp,h}. But if you look at the setting functions, almost all of them deal with the page_settings, that is an WebCore::Settings and we get it from the page. And the page is relative to the view.
> 
> And the ones that don't do that, depend at least on the frame loader, that need a frame, thus usually associated with a view.
> 
> In the ewk_settings.cpp, all functions deal with settings that are independent of the view, that are set globally, so we don't need a view.
> 
> Anyway, your patch looks good to me.

Hello antognolli,

I understand your comments. OK, Let's keep current architecture for a while. If I find good solution, I wiil discuss it with you guys again. :)

Thanks,
Gyuyoung Kim

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.