[Webkit-unassigned] [Bug 45446] [EFL] Add setting API to set a local storage database path.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 06:35:41 PDT 2010


Rafael Antognolli <antognolli at profusion.mobi> changed:

           What    |Removed                     |Added
                 CC|                            |antognolli at profusion.mobi,
                   |                            |kenneth at webkit.org,
                   |                            |tonikitoo at webkit.org

--- Comment #3 from Rafael Antognolli <antognolli at profusion.mobi>  2010-09-10 06:35:41 PST ---
Hi Gyuyoung,

Yes, from an organisational point of view, you are right, we should move all setting functions to ewk_settings.{cpp,h}. But if you look at the setting functions, almost all of them deal with the page_settings, that is an WebCore::Settings and we get it from the page. And the page is relative to the view.

And the ones that don't do that, depend at least on the frame loader, that need a frame, thus usually associated with a view.

In the ewk_settings.cpp, all functions deal with settings that are independent of the view, that are set globally, so we don't need a view.

Anyway, your patch looks good to me.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list