[Webkit-unassigned] [Bug 25673] [GTK] ATs should be able to select/unselect text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25673


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67206|0                           |1
        is obsolete|                            |
  Attachment #67208|                            |review?
               Flag|                            |




--- Comment #12 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-10 11:27:39 PST ---
Created an attachment (id=67208)
 --> (https://bugs.webkit.org/attachment.cgi?id=67208)
Path proposal + Unit tests

(In reply to comment #11)
> (From update of attachment 67206 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67206&action=prettypatch
> 
> > WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:112
> > +    if (!textLength) {
> This should probably be an early return.
> 
> > WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:346
> > +{
> I like this a lot better, but I'd rather see early returns. :/
> 
> Looks good! r=me, but please switch to using early returns before landing.

Here you have a new version.

BTw, I'm not asking for cq+ for now because we must make sure patch for 26991 are landed first (hence, I'll ask for cq+ later)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.