[Webkit-unassigned] [Bug 25673] [GTK] ATs should be able to select/unselect text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25673


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67206|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2010-09-10 11:12:16 PST ---
(From update of attachment 67206)
View in context: https://bugs.webkit.org/attachment.cgi?id=67206&action=prettypatch

> WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:112
> +    if (!textLength) {
This should probably be an early return.

> WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:346
> +{
I like this a lot better, but I'd rather see early returns. :/

Looks good! r=me, but please switch to using early returns before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.