[Webkit-unassigned] [Bug 45449] Extract the code to find special ancestors in createMarkup into a function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 00:07:43 PDT 2010


--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2010-09-10 00:07:43 PST ---
Thanks for the review.  Sorry about a delayed commit.  I had to push regression fix first.

(In reply to comment #2)
> (From update of attachment 67014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67014&action=prettypatch
> > WebCore/editing/markup.cpp:961
> > +    Node* specialCommonAncestor = 0;
> > +    if (shouldAnnotate == AnnotateForInterchange) {
> > +        specialCommonAncestor = ancestorToRetainStructureAndAppearance(commonAncestor);
> Nit: You may want to copy the comment that was around here about which ancestor you want to include.  It's not obvious why we might want the specialCommonAncestor (ie., what makes it special).  Maybe the comment should just go above this function.

Will do.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list