[Webkit-unassigned] [Bug 45449] Extract the code to find special ancestors in createMarkup into a function

Thu Sep 9 11:27:41 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45449

Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67014|review?                     |review+
               Flag|                            |

--- Comment #2 from Tony Chang <tony at chromium.org>  2010-09-09 11:27:41 PST ---
(From update of attachment 67014)
View in context: https://bugs.webkit.org/attachment.cgi?id=67014&action=prettypatch

> WebCore/editing/markup.cpp:961
> +    Node* specialCommonAncestor = 0;
> +    if (shouldAnnotate == AnnotateForInterchange) {
> +        specialCommonAncestor = ancestorToRetainStructureAndAppearance(commonAncestor);
Nit: You may want to copy the comment that was around here about which ancestor you want to include.  It's not obvious why we might want the specialCommonAncestor (ie., what makes it special).  Maybe the comment should just go above this function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.