[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44127





--- Comment #64 from W. James MacLean <wjmaclean at chromium.org>  2010-09-09 12:10:13 PST ---
(In reply to comment #63)
> (From update of attachment 67071 [details])
> I like the new clean look!  Thanks for taking the time to make the change.

No problem!

> View in context: https://bugs.webkit.org/attachment.cgi?id=67071&action=prettypatch
> 
> > WebKit/chromium/src/WebViewImpl.cpp:969
> > +#error Must port to your platform.
> Looks like other parts of the code (e.g. WebFrameImpl::paint()) call notImplemented() instead of giving a compiler error.  Maybe follow that precedent here?

Sure.

> > WebKit/chromium/src/WebViewImpl.cpp:978
> > +        gc.translate(FloatSize(0.0f, bitmapHeight));
> Isn't the flip necessary for only one of the two platforms?

I've tried it on both Mac & Linux (expecting Mac not to need the flip), but I'm guessing that something inside GraphicsContext must unflip the flip for Mac, so that both platforms have the same interface.

I'm verifying this all works properly for rect not equal to the texture layer rect, and will re-upload a patch when I have done so, and made the other change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.