[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44127





--- Comment #63 from Vangelis Kokkevis <vangelis at chromium.org>  2010-09-09 11:54:04 PST ---
(From update of attachment 67071)
I like the new clean look!  Thanks for taking the time to make the change.

View in context: https://bugs.webkit.org/attachment.cgi?id=67071&action=prettypatch

> WebKit/chromium/src/WebViewImpl.cpp:969
> +#error Must port to your platform.
Looks like other parts of the code (e.g. WebFrameImpl::paint()) call notImplemented() instead of giving a compiler error.  Maybe follow that precedent here?

> WebKit/chromium/src/WebViewImpl.cpp:978
> +        gc.translate(FloatSize(0.0f, bitmapHeight));
Isn't the flip necessary for only one of the two platforms?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.