[Webkit-unassigned] [Bug 45292] V8 generated code is missing include of V8BindingMacros.h for STRING_TO_V8PARAMETER_EXCEPTION_BLOCK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45292





--- Comment #11 from anton muhin <antonm at chromium.org>  2010-09-07 08:13:57 PST ---
(In reply to comment #10)
> > Just in case: I've added more cases to use the macro.  I hope you already have
> > necessary includes on those paths.
> It looks like the macro is only used from ConvertToV8Parameter(), to which this patch adds the include, so I think we're OK.
> 
> Anton, do you know if the include from GenerateNormalAttrSetter() can be removed, or are you happy with this patch as it is?

Yes, you're right.  I think it's the best place for inclusion and we don't want to specialize unless build time is prohibitive (which should not be the case, hopefully)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.