[Webkit-unassigned] [Bug 45292] V8 generated code is missing include of V8BindingMacros.h for STRING_TO_V8PARAMETER_EXCEPTION_BLOCK

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 08:02:20 PDT 2010


--- Comment #10 from Steve Block <steveblock at google.com>  2010-09-07 08:02:21 PST ---
> Sorry guys for introducing this.  Could we setup BBs to watch for Android
> breakage?
No problem. We'd love to have an Android BB, but we have a lot of upstreaming to do first!

> Just in case: I've added more cases to use the macro.  I hope you already have
> necessary includes on those paths.
It looks like the macro is only used from ConvertToV8Parameter(), to which this patch adds the include, so I think we're OK.

Anton, do you know if the include from GenerateNormalAttrSetter() can be removed, or are you happy with this patch as it is?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list