[Webkit-unassigned] [Bug 44950] [WML] Add create functions to WML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44950


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66693|0                           |1
        is obsolete|                            |
  Attachment #66697|                            |review?, commit-queue?
               Flag|                            |




--- Comment #15 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-09-07 02:19:03 PST ---
Created an attachment (id=66697)
 --> (https://bugs.webkit.org/attachment.cgi?id=66697)
Patch

No Problem, I fix it again. BTW, when I change " WMLFormControlElement(const QualifiedName&, Document*);" with private, there are build breaks as below,

==================================================================================================
/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLFormControlElement.h: In constructor ‘WebCore::WMLOptGroupElement::WMLOptGroupElement(const WebCore::QualifiedName&, WebCore::Document*)’:
/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLFormControlElement.h:49: error: ‘WebCore::WMLFormControlElement::WMLFormControlElement(const WebCore::QualifiedName&, WebCore::Document*)’ is private
/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLOptGroupElement.cpp:39: error: within this context
[  9%] Building CXX object WebCore/CMakeFiles/webcore_efl.dir/wml/WMLPrevElement.cpp.o
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLOptGroupElement.cpp.o] 오류 1
make[2]: *** 끝나지 않은 작업을 기다리고 있습니다....

/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLFormControlElement.h: In constructor ‘WebCore::WMLInputElement::WMLInputElement(const WebCore::QualifiedName&, WebCore::Document*)’:
/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLFormControlElement.h:49: error: ‘WebCore::WMLFormControlElement::WMLFormControlElement(const WebCore::QualifiedName&, WebCore::Document*)’ is private
/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLInputElement.cpp:44: error: within this context
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLInputElement.cpp.o] Error 1
/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLFormControlElement.h: In constructor ‘WebCore::WMLOptionElement::WMLOptionElement(const WebCore::QualifiedName&, WebCore::Document*)’:
/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLFormControlElement.h:49: error: ‘WebCore::WMLFormControlElement::WMLFormControlElement(const WebCore::QualifiedName&, WebCore::Document*)’ is private
/home/gyuyoung/webkit/WebKit-WML/WebCore/wml/WMLOptionElement.cpp:38: error: within this context
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLOptionElement.cpp.o] Error 1
==================================================================================================

I think WMLOptGroupElement and WMLInputElement invoke the Ctor as below. So, I move the Ctor to public again. Is this OK ?

==================================================================================================
WMLOptGroupElement::WMLOptGroupElement(const QualifiedName& tagName, Document* doc)
    : WMLFormControlElement(tagName, doc)

WMLInputElement::WMLInputElement(const QualifiedName& tagName, Document* doc)
    : WMLFormControlElement(tagName, doc)
==================================================================================================

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.