[Webkit-unassigned] [Bug 44950] [WML] Add create functions to WML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44950


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66693|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #14 from Dirk Schulze <krit at webkit.org>  2010-09-07 02:01:16 PST ---
(From update of attachment 66693)
View in context: https://bugs.webkit.org/attachment.cgi?id=66693&action=prettypatch

> WebCore/wml/WMLIntrinsicEvent.h:38
> +    static PassRefPtr<WMLIntrinsicEvent> create(const QualifiedName&, Document*);
> +
I'm realy sorry, I looked at Maciejs patch again. I think the new constructor doesn't make sense. Maciej may made a mistake here. The new create function and the new constructor are wrong in this context. Please undo the changes except of the coding style change and delete PassRefPtr<WMLIntrinsicEvent> create(const QualifiedName&, Document*); from WebCore/wml/WMLIntrinsicEvent.cpp instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.