[Webkit-unassigned] [Bug 45095] absolutely positioned list in inline element crashes

Fri Sep 3 07:49:26 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45095

--- Comment #6 from Shinichiro Hamaji <hamaji at chromium.org>  2010-09-03 07:49:26 PST ---
> Can you explain the significance of returning a node that is rendered as a block?

In the test case, the first <li> considers <body> is its enclosing node and the second <li>'s enclosing node is <span>. If we ignore <span>, the second <li> also consider's <body> as its enclosing node, so the two <li>s have the same enclosing node and previousListItem returns <body> before it touches a NULL renderer. Also, given <ul> and <ol> are blocks, I couldn't imagine the case where having always block enclosing nodes, though it's not good if the document element can be inline.

Anyway, as I wrote, I'm not sure if this fix is the best. Perhaps we need to change the position of the continued <span>, but I'm not sure if it's easy to fix this bug this way.

The current render tree is like

RenderView 0x11477fc                   #document       0x886f000
  RenderBlock 0x11af77c                 HTML    0x1161150
    RenderBody 0x114302c                BODY    0x11a4460
      RenderBlock (anonymous) 0x11a8d0c
        RenderInline 0x11a74bc          SPAN    0x11afca0
          RenderText 0x11ab47c          #text   0x1154e60 "\n"
      RenderBlock (anonymous) 0x11abccc
        RenderListItem 0x11afe0c        LI      0x11a95d0
      RenderBlock (anonymous) 0x11a8b8c
        RenderInline 0x11a85ec          SPAN    0x11afca0
          RenderListItem 0x11a845c      LI      0x11a87b0 STYLE=position:absolute

The above render tree isn't good and it should be like the following?

RenderView 0x11477fc                   #document       0x886f000
  RenderBlock 0x11af77c                 HTML    0x1161150
    RenderBody 0x114302c                BODY    0x11a4460
      RenderBlock (anonymous) 0x11a8d0c
        RenderInline 0x11a74bc          SPAN    0x11afca0
          RenderText 0x11ab47c          #text   0x1154e60 "\n"
      RenderBlock (anonymous) 0x11abccc
        RenderListItem 0x11afe0c        LI      0x11a95d0
      RenderBlock (anonymous) 0x11a8b8c
        RenderListItem 0x11a845c        LI      0x11a87b0 STYLE=position:absolute
      RenderBlock (anonymous) 0x11a8bXX
        RenderInline 0x11a85ec          SPAN    0x11afca0

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.