[Webkit-unassigned] [Bug 45095] absolutely positioned list in inline element crashes

Thu Sep 2 09:12:23 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45095

--- Comment #5 from mitz at webkit.org  2010-09-02 09:12:23 PST ---
(In reply to comment #4)
> Thanks for your review!
> 
> > The comment says the the first found node is used, but you changed it to be the first found node that is rendered as a block. Why is this the right thing to do? What if the document element itself is not a RenderBlock? Can this function return 0?
> 
> I think we still have <html> as the last block element? Can this be missing or inline? I think I've never seen the case where the HTML element is inline, but of course I may be wrong. If I'm wrong, Could you tell me how I can make the root element inline? I've updated the comment for now.

I was wrong. The document element is indeed forced to be a block. However, according to the comment in <http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderView.cpp#L211> this may not always be the case.

> By the way, I don't really know what we should do when there are no <ul> and <ol>. I guess this case is not specified well. FYI, Firefox seems to output "0", not "II" for the test case. If we should prefer Firefox's behavior, I'll update my patch. I like the current WebKit's behavior though.
> 
> Thanks!

Can you explain the significance of returning a node that is rendered as a block?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.