[Webkit-unassigned] [Bug 47903] [EFL] Sets default user agent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47903


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com
                   |kit.org                     |
     Ever Confirmed|0                           |1
  Attachment #71528|0                           |1
        is obsolete|                            |
  Attachment #71528|review?, commit-queue?      |
               Flag|                            |
  Attachment #72481|                            |review?, commit-queue?
               Flag|                            |




--- Comment #17 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-10-31 18:56:51 PST ---
Created an attachment (id=72481)
 --> (https://bugs.webkit.org/attachment.cgi?id=72481&action=review)
Patch

I define user agent version macros in cmake/OptionEfl.cmake as PROJECT_VERSION_XXX.

So, the WEBKIT_USER_AGENT_MAJOR_VERSION / WEBKIT_USER_AGENT_MINOR_VERSION macro's vaules are also set from cmake/OptionsEfl.cmake, and they are set during the build time.

  8 #define WEBKIT_USER_AGENT_MAJOR_VERSION @USER_AGENT_VERSION_MAJOR@
  9 #define WEBKIT_USER_AGENT_MINOR_VERSION @USER_AGENT_VERSION_MINOR@


Kenneth,

How do you think about this approach ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.