[Webkit-unassigned] [Bug 47903] [EFL] Sets default user agent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47903





--- Comment #16 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-10-31 18:51:59 PST ---
(In reply to comment #15)
> $~/git/WebKit/WebKit/gtk$ grep -rn WEBKIT_MINOR_VERSION *
> docs/GNUmakefile.in:211:WEBKIT_MINOR_VERSION = @WEBKIT_MINOR_VERSION@
> docs/webkitgtk-sections.txt:633:WEBKIT_MINOR_VERSION
> webkit/webkitversion.h.in:29:#define WEBKIT_MINOR_VERSION (@WEBKIT_MINOR_VERSION@)
> webkit/webkitversion.h.in:37:  (WEBKIT_MAJOR_VERSION == (major) && WEBKIT_MINOR_VERSION > (minor)) || \
> webkit/webkitversion.h.in:38:  (WEBKIT_MAJOR_VERSION == (major) && WEBKIT_MINOR_VERSION == (minor) && \
> webkit/webkitversion.cpp:48:    return WEBKIT_MINOR_VERSION;
> 
> You can get the WebKit version during building it.

Yes, the version macros are defined in configure.ac file.

- configure.ac
   3 m4_define([webkit_major_version], [1])
   4 m4_define([webkit_minor_version], [3])
   5 m4_define([webkit_micro_version], [5])
   6 
   7 # This is the version we'll be using as part of our User-Agent string
   8 # e.g., AppleWebKit/$(webkit_user_agent_version) ...
   9 #
  10 # Sourced from WebCore/Configurations/Version.xcconfig
  11 m4_define([webkit_user_agent_major_version], [534])
  12 m4_define([webkit_user_agent_minor_version], [7])
...
  23 WEBKIT_MAJOR_VERSION=webkit_major_version
  24 WEBKIT_MINOR_VERSION=webkit_minor_version
  25 WEBKIT_MICRO_VERSION=webkit_micro_version
  26 WEBKIT_USER_AGENT_MAJOR_VERSION=webkit_user_agent_major_version
  27 WEBKIT_USER_AGENT_MINOR_VERSION=webkit_user_agent_minor_version

But, as you know, WebKit EFL cannot use the configure.ac file. So, I define the version macros in cmakeconfig.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.