[Webkit-unassigned] [Bug 48127] [Qt][WK2] Plugin initialization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48127





--- Comment #23 from Balazs Kelemen <kbalazs at webkit.org>  2010-10-27 14:57:57 PST ---
(In reply to comment #17)
> (From update of attachment 72084 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72084&action=review
> 
> > WebCore/plugins/unix/UNIXPluginQuirks.cpp:139
> > +#if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6)
> > +    // Passing a 32-bit depth pixmap to NPAPI plugins is too inefficient. Instead, pass a X Pixmap
> > +    // that has same depth as the screen depth since graphics operations are optimized
> > +    // for this depth.
> > +    quirks->add(PluginQuirkRequiresDefaultScreenDepth);
> > +#endif
> 
> This seems qt specific and it is not inside #if PLATFORM(QT). Maybe that would make it more clean that it is a Qt workaround?

Right.

> 
> > WebCore/plugins/unix/UNIXPluginQuirks.h:51
> > +class UNIXPluginQuirks {
> 
> Remember Mac is UNIX as well.

True.

>
> 
> > WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:86
> > +void NetscapePlugin::platformPreInitialize(Parameters*)
> > +{
> > +}
> 
> No comment to why this is empty?

I think this is self documenting. A platform method that does nothing
=> there is nothing to do on that platform at that point :)
I can add a comment however.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.