[Webkit-unassigned] [Bug 48127] [Qt][WK2] Plugin initialization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48127





--- Comment #22 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-10-27 14:37:53 PST ---
(In reply to comment #21)
> I don't think it will become an ifdef hell - we'll have something like
> 
> #if PLATFORM(MAC)
> #define PLUGIN_ARCHITECTURE_MAC 1
> #elif PLATFORM(WIN)
> #define PLUGIN_ARCHITECTURE_WIN 1
> #elif PLATFORM(QT)
> #if (qt for mac)
> #define PLUGIN_ARCHITECTURE_MAC 1
> #elif (qt for x11)
> #define PLUGIN_ARCHITECTURE_X11
> #endif
> #endif
> 
> I also think that this patch should be split up. The quirk refactoring could definitely be done as a separate patch.

Yes, this is a good suggestion. I also agree that the patch needs to be split up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.