[Webkit-unassigned] [Bug 5793] HTML OBJECT without width/height attributes doesn't honor the size of the image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5793


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72053|review?                     |review-
               Flag|                            |




--- Comment #24 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-10-27 12:51:07 PST ---
(From update of attachment 72053)
View in context: https://bugs.webkit.org/attachment.cgi?id=72053&action=review

Making progress!  r- to fix the ChangeLog patch, to use view->size(), and to include a layout test.

This page (under the "Regression tests" section) talks about how to make a layout test:  <http://webkit.org/coding/contributing.html>

It's probably just as easy to look at existing layout tests to figure out how to write one.

Note that I haven't reviewed this patch for correctness of behavior yet--just getting through some of the basic issues first.  Comment #21 concerns me, though, in that these changes don't fix the test cases attached to the bug.

> WebCore/ChangeLog:-106
> -2010-10-27  Adam Roben  <aroben at apple.com>

The ChangeLog patch is still deleting old ChangeLog entries.  There should only be the new ChangeLog added to the top of the file.

> WebCore/html/ImageDocument.cpp:300
> +        IntSize windowSize = IntSize(view->width(), view->height());

Please change to:

    IntSize windowSize = view->size();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.