[Webkit-unassigned] [Bug 5793] HTML OBJECT without width/height attributes doesn't honor the size of the image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5793





--- Comment #23 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-10-27 12:43:37 PST ---
(In reply to comment #19)
> Thank you for your time for review.
> I have some questions.
> 
> (In reply to comment #18)
> ....
> > > WebCore/ChangeLog:12
> > > +        No new tests. (OOPS!)
> > 
> > Did you try to write a test case for this change?
> If I need to create new test case for it, I think I can use this attached test case on this issue.
> Is it acceptable?

The attached test case needs to be turned into a layout test (under the LayoutTests directory structure) and the test and its results need to be part of the patch.

> > Did you run layout tests to see if any existing layout test results changed?
> I run 'run-webkit-tests' script with this patch. There was no problem.
> Is it not enough? Do I need any other test?

Nope, that's good.  I didn't see anywhere that you had mentioned doing it, which is why I asked.

> > > WebCore/html/ImageDocument.cpp:301
> > > +    IntSize windowSize = IntSize(view->width(), view->height());
> > 
> > Is there a FrameView::size() method that returns an IntSize?
> I followed 'ImageDocument::imageFitsInWindow()'. It uses 'IntSize windowSize = IntSize(view->width(), view->height());'.
> Do I need to change it to 'FrameView::size()'?

Using view->size() would be slightly less work.  I would change it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.