[Webkit-unassigned] [Bug 5793] HTML OBJECT without width/height attributes doesn't honor the size of the image

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 10:22:23 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=5793


Julie Jeongeun Kim <jiyuluna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72031|0                           |1
        is obsolete|                            |
  Attachment #72053|                            |review?
               Flag|                            |




--- Comment #20 from Julie Jeongeun Kim <jiyuluna at gmail.com>  2010-10-27 10:22:22 PST ---
Created an attachment (id=72053)
 --> (https://bugs.webkit.org/attachment.cgi?id=72053&action=review)
Proposed patch with accepting reviewer's comment.

I changed code additionally.
1.Removed code for debugging.
2.Kept 'IntSize windowSize = IntSize(view->width(), view->height());' but I added null check, as other APIs in ImageDocument did.
3.condition and declaration were combined.

As to new test case,
I think the test case attached here is suitable.
Please let me know how to apply it.

* I've done other tests with 'run-webkit-tests'. 

Thanks,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list