[Webkit-unassigned] [Bug 5793] HTML OBJECT without width/height attributes doesn't honor the size of the image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5793





--- Comment #19 from Julie Jeongeun Kim <jiyuluna at gmail.com>  2010-10-27 08:07:26 PST ---
Thank you for your time for review.
I have some questions.

(In reply to comment #18)
....
> > WebCore/ChangeLog:12
> > +        No new tests. (OOPS!)
> 
> Did you try to write a test case for this change?
If I need to create new test case for it, I think I can use this attached test case on this issue.
Is it acceptable?

> Did you run layout tests to see if any existing layout test results changed?
I run 'run-webkit-tests' script with this patch. There was no problem.
Is it not enough? Do I need any other test?

...
> > WebCore/html/ImageDocument.cpp:301
> > +    IntSize windowSize = IntSize(view->width(), view->height());
> 
> Is there a FrameView::size() method that returns an IntSize?
I followed 'ImageDocument::imageFitsInWindow()'. It uses 'IntSize windowSize = IntSize(view->width(), view->height());'.
Do I need to change it to 'FrameView::size()'?

Please check.
Thanks,
Julie

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.