[Webkit-unassigned] [Bug 48339] Add a 'grammar' attribute for speech input.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48339





--- Comment #3 from Satish Sampath <satish at chromium.org>  2010-10-26 13:29:24 PST ---
(From update of attachment 71904)
View in context: https://bugs.webkit.org/attachment.cgi?id=71904&action=review

Thanks, addressed the comments. Will land.

>> WebCore/page/SpeechInputClient.h:34
>> +#include <wtf/Forward.h>
> 
> Needed?

Yes since we are using WTF::String in the added code below.

>> WebCore/platform/mock/SpeechInputClientMock.cpp:53
>> +bool SpeechInputClientMock::startRecognition(int requestId, const IntRect&, const String&)
> 
> include name

Done

>> WebCore/platform/mock/SpeechInputClientMock.h:53
>> +    bool startRecognition(int, const IntRect&, const String&);
> 
> include name

Done

>> WebKit/chromium/src/SpeechInputClientImpl.h:57
>> +    bool startRecognition(int, const WebCore::IntRect&, const WTF::String&);
> 
> you should include a name here

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.