[Webkit-unassigned] [Bug 48339] Add a 'grammar' attribute for speech input.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48339


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71904|review?                     |review+
               Flag|                            |




--- Comment #2 from Jeremy Orlow <jorlow at chromium.org>  2010-10-26 12:08:24 PST ---
(From update of attachment 71904)
View in context: https://bugs.webkit.org/attachment.cgi?id=71904&action=review

r=me

> WebCore/page/SpeechInputClient.h:34
> +#include <wtf/Forward.h>

Needed?

> WebCore/platform/mock/SpeechInputClientMock.cpp:53
> +bool SpeechInputClientMock::startRecognition(int requestId, const IntRect&, const String&)

include name

> WebCore/platform/mock/SpeechInputClientMock.h:53
> +    bool startRecognition(int, const IntRect&, const String&);

include name

> WebKit/chromium/src/SpeechInputClientImpl.h:57
> +    bool startRecognition(int, const WebCore::IntRect&, const WTF::String&);

you should include a name here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.