[Webkit-unassigned] [Bug 48032] [chromium] Added PluginLayerChromium for hardware accelerated compositing of plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48032





--- Comment #9 from Vangelis Kokkevis <vangelis at chromium.org>  2010-10-25 09:50:59 PST ---
> 
> > > WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:736
> > > +            || !m_videoLayerSharedValues->initialized() || !m_pluginLayerSharedValues->initialized()) {
> > 
> > formating: || should align with !m_layerSharedValues of the line above it
> > 
> 
> Done but now webkit-check-style says it should be to the right on the line above.
> 
It's because the boolean || needs to be moved to the line below but line up with the contents of line above.

> > > WebCore/platform/graphics/chromium/PluginLayerChromium.cpp:117
> > > +    GLC(context, context->texParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST));
> > 
> > It's somewhat wasteful to set the sampler settings every time you draw.  This block of 4 sets could move to setTextureId() ?
> >
> 
> I will optimize this later.
> 

Please add a FIXME so that we don't forget.


> > > WebKit/chromium/src/WebPluginContainerImpl.cpp:410
> > > +    unsigned backingTextureId = m_webPlugin->getBackingTextureId();
> > 
> > In a lost context scenario, the GL context used by the compositor will change.  The texture used by the plugin needs to be re-created and passed again to the layer. I'm realizing that none of the other layer types that manage their own textures (e.g. Video and WebGL) do that correctly either.
> >
> 
> I will address this when we get the accelerated compositor recovering from context lost.
> 
Please add a FIXME

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.