[Webkit-unassigned] [Bug 48032] [chromium] Added PluginLayerChromium for hardware accelerated compositing of plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48032





--- Comment #8 from Vangelis Kokkevis <vangelis at chromium.org>  2010-10-25 09:48:20 PST ---
(From update of attachment 71615)
View in context: https://bugs.webkit.org/attachment.cgi?id=71615&action=review

> WebCore/ChangeLog:10
> +        * loader/SubframeLoader.cpp:

You'll need to regenerate the ChangeLog or remove SubframeLoader entry.

> WebKit/chromium/public/WebPlugin.h:70
> +    // TODO(apatrick): Make this pure virtual once this change is rolled into chromium.

WebKit doesn't have TODO(name).  Please use "FIXME" instead (no name)

> WebKit/chromium/public/WebPluginContainer.h:59
> +    // TODO(apatrick): Make this pure virtual once this change is rolled into chromium.

Same for this TODO

> WebKit/chromium/public/WebPluginContainer.h:63
> +    // TODO(apatrick): Make this pure virtual once this change is rolled into chromium.

And here

> WebKit/chromium/src/WebPluginContainerImpl.cpp:292
> +

nit: typically there are no blank after the #if or before the #end

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.