[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443





--- Comment #39 from Gustavo Noronha (kov) <gns at gnome.org>  2010-10-21 05:52:35 PST ---
(In reply to comment #37)
> Thank you for your comments.
> Before updating the patch, I'd like to confirm the following issues,
> 
> 1) Add "void webkit_web_view_recompute_viewport_attributes(WebKitWebView* webView, gint availableWidth, gint availableHeight) instead of webkit_viewport_recompute to trigger a viewport-attribute-changed signal.
> 
> It seems to be easier to trigger the signal in WebKitWebView.  Also, we still need the availableWidth/Height parameters although these values are able to be obtained in WebKit. Because, DRT needs this function given arbitrary availableWidth/height for testing. 
> Instead, we can remove webkit_viewport_attributes_computation.

No, my idea is that WebKitViewportAttributes will keep a weak reference to the WebView. We will have this function:

void webkit_viewport_attributes_recompute(WebKitViewport*);

It will trigger the signal. While handling the signal you have to set availableWidth/Height on the ViewportAttributes object. No need for any other function for these.

If there's something DRT needs it's fine to have, but it should _not_ be public API just because DRT needs it. There are plenty of functions that we already use in DRT that are not public API (they are in webkitprivate.h), you can use them as example =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.