[Webkit-unassigned] [Bug 47810] [HTML5] Add DOMSettableTokenList

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 20 20:02:46 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47810





--- Comment #17 from Kenichi Ishibashi <bashi at google.com>  2010-10-20 20:02:45 PST ---
Hi Erik,

(In reply to comment #15)
> If we add add and remove to SpaceSplitString/SpaceSplitStringData we should operate on the vector which allows us to do faster add and removes. I really don't want SpaceSplitString to carry the burden of the white space preserving semantics of DOMTokenList and I don't think it makes sense to tear down and rebuild the vector for adds and removes.

Oh, I misunderstood what you were getting at. I've modified add() and remove() following your suggestion.

> > WebCore/dom/SpaceSplitString.cpp:111
> > +void SpaceSplitStringData::remove(const AtomicString& string)
> 
> Lets keep this silly algorithm in DOMTokenList ;-)

OK, I've put it in DOMTokenList again:-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list