[Webkit-unassigned] [Bug 47810] [HTML5] Add DOMSettableTokenList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47810





--- Comment #16 from Kenichi Ishibashi <bashi at google.com>  2010-10-20 18:21:51 PST ---
Kent-san,

Thank you very much for reviewing!

(In reply to comment #14)
> I think WebCore/Android.mk and WebCore/CMakeList.txt need to have ClassLis.cpp.

I'll add ClassList.cpp into these files in next patch. BTW, as for WebCore/Android.mk, it doesn't contain DOMTokenList.cpp so it was difficult to determine whether I have to put new files into WebCore/Android.mk (and other build files). Should I also include DOMTokenList.cpp in this file? Is there any guideline for that?

> You should add a comment to each of files/functions in ChangeLog as possible.
> In this case, you can add comments like
>  - "Add <new files>" for build files
>  - "Moved from Foobar.cpp" for copied functions
> Such comments would be very helpful for reviewing.

Sorry for inconvenience you. I'll add a comment from next time.

> We don't use TODO(username): style in WebKit.  Just put FIXME: please.

Done.

> > WebCore/dom/SpaceSplitString.h:79
> > +        void add(const AtomicString& string) { if (m_data) m_data->add(string); }
> 
> Please move the implementation to SpaceSplitString.cpp.

Done.

> > WebCore/dom/SpaceSplitString.h:80
> > +        void remove(const AtomicString& string) { if (m_data) m_data->remove(string); }
> 
> ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.