[Webkit-unassigned] [Bug 44158] [soup] implement ResourceHandle::platformSetDefersLoading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44158





--- Comment #16 from Philippe Normand <pnormand at igalia.com>  2010-10-20 01:26:11 PST ---
(In reply to comment #15)
> (From update of attachment 71176 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71176&action=review
> 
> > WebCore/platform/network/soup/ResourceHandleSoup.cpp:739
> > +    // Only supported for http(s) transfers. Something similar would
> > +    // probably be needed for data transfers done with GIO.
> 
> This comment is inaccurate now that data URLs are handled by soup, I think. :)
> 

Well I think it's still accurate ;) m_soupMessage is created only in startHttp(). startData and the data uri loading doesn't use it, afaics.

> > WebCore/platform/network/soup/ResourceHandleSoup.cpp:746
> > +    else
> > +        soup_session_unpause_message(defaultSession(), d->m_soupMessage.get());
> 
> I think this presents a problem. The time between the creation of m_soupRequest and m_soupMessage is an asynchronous call. If setDefersLoading(...) was called while that call was in progress, the message would not be paused properly. Perhaps there should be a companion call to soup_session_pause_message if the message is m_defersLoading is true in sendRequestCallback.

Hum, that's right indeed. Will send a new patch, thanks for reviewing :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.