[Webkit-unassigned] [Bug 44158] [soup] implement ResourceHandle::platformSetDefersLoading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44158


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71176|review?                     |review-
               Flag|                            |




--- Comment #15 from Martin Robinson <mrobinson at webkit.org>  2010-10-19 09:48:32 PST ---
(From update of attachment 71176)
View in context: https://bugs.webkit.org/attachment.cgi?id=71176&action=review

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:739
> +    // Only supported for http(s) transfers. Something similar would
> +    // probably be needed for data transfers done with GIO.

This comment is inaccurate now that data URLs are handled by soup, I think. :)

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:746
> +    else
> +        soup_session_unpause_message(defaultSession(), d->m_soupMessage.get());

I think this presents a problem. The time between the creation of m_soupRequest and m_soupMessage is an asynchronous call. If setDefersLoading(...) was called while that call was in progress, the message would not be paused properly. Perhaps there should be a companion call to soup_session_pause_message if the message is m_defersLoading is true in sendRequestCallback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.