[Webkit-unassigned] [Bug 40139] [GTK] Widgets do not support CSS transformations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40139


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71083|review?                     |
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2010-10-19 10:21:41 PST ---
(From update of attachment 71083)
View in context: https://bugs.webkit.org/attachment.cgi?id=71083&action=review

>> LayoutTests/ChangeLog:14
>> +        * platform/gtk/fast/forms/slider-transformed-expected.txt: Added.
> 
> I think this file is not in the patch.

It's the third one down on the pretty-diff. :)

>> WebCore/platform/gtk/RenderThemeGtk.cpp:169
>> +#endif
> 
> I was wondering if we could move this code and m_theme attributes to the WidgetRenderingContext object or to the gtkxdrawing. In any case we could leave it for future patches.

It needs to stay here as long as RenderThemeGtk manages widgets itself. Perhaps if we eventually do away with WidgetRenderingContext (when the style changes land in GTK+ for instance) it might make sense to move it.

>> WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp:149
>> +                          m_targetRect.y() - m_extraSpace.height());
> 
> I think we can use IntRect and inflate to simplify this code.

Hrm. Maybe IntPoint targetOrigin = m_targetRect.topLeft - toPoint(m_extraSpace);

>> WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp:51
>>  
> 
> I needed these modifications to compile WidgetRenderingContextGtk3.cpp:
> 
> 
> diff --git a/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp b/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp
> index 693c40e..bd826d9 100644
> --- a/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp
> +++ b/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp
> @@ -32,12 +32,12 @@ WidgetRenderingContext::WidgetRenderingContext(GraphicsContext* graphicsContext,
>      : m_graphicsContext(graphicsContext)
>      , m_targetRect(targetRect)
>      , m_paintRect(targetRect)
> -    , m_target(context->platformContext())
>      , m_hadError(false)
> +    , m_target(graphicsContext->platformContext())
>  {
>  }
> 
> -~WidgetRenderingContext::WidgetRenderingContext()
> +WidgetRenderingContext::~WidgetRenderingContext()
>  {
>  }
> 
> @@ -47,4 +47,6 @@ bool WidgetRenderingContext::paintMozillaWidget(GtkThemeWidgetType type, GtkWidg
>      return !m_hadError;
>  }
> 
> +}
> +
>  #endif // !GTK_API_VERSION_2

Thanks. I'll post a new patch with these fixes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.